Re: x86/.../trampoline_64.S racy?

From: Pavel Machek
Date: Fri Feb 01 2008 - 19:08:02 EST


On Fri 2008-02-01 23:07:16, Pavel Machek wrote:
> Hi!
>
> I'm trying to reuse trampoline_64.S for wakeup from ACPI s3... but I'm
> getting some badness: If I insert delay loops into trampoline_64.S,
> machine fails to boot; but I already increased cpu bootup delay to 200
> seconds...
>
> Is it possible that bootup is subtly racy somewhere?

No, I just missed another place with timeout:

/*
* Wait 5s total for a response
*/
for (timeout = 0; timeout < 5000000; timeout++) {
if (cpu_isset(cpu, cpu_callin_map))
break; /* It has booted */
udelay(100);
}

Pavel

--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/