Re: [PATCH 1/5] hrtimer_nanosleep: use -EINTR, not -ERESTARTNOHAND

[Oleg Nesterov]

On 02/01, Thomas Gleixner wrote:
>
> On Fri, 1 Feb 2008, Oleg Nesterov wrote:
> 
> > hrtimer_nanosleep:
> > 
> > 	/* Absolute timers do not update the rmtp value and restart: */
> > 	return -ERESTARTNOHAND;
> > 
> > This is not right, -ERESTARTNOHAND means we will do restart if there is no
> > in fact pending signal, and worse, this restart will use the same unchanged
> > "__user *rmtp" parameter.
> 
> -ERESTARTNOHAND is safe here. We want to restart the timer.

Ah. I was greatly confused by the comment, it says "do not ... restart",
now I understand what this _actually_ means.

And yes, I was wrong. If restart is wanted, it is safe to use the original
*rqtp, the timer is HRTIMER_MODE_ABS.

Thanks Thomas!

Andrew, please ignore this patch.

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/