Re: [PATCH 2/2] Char: applicom, use pci_match_id

From: Jiri Slaby
Date: Thu Jan 31 2008 - 04:26:44 EST


On 01/31/2008 12:10 AM, Andrew Morton wrote:
On Wed, 30 Jan 2008 12:13:15 +0100
Jiri Slaby <jirislaby@xxxxxxxxx> wrote:

+ if (!pci_match_id(applicom_pci_tbl, dev));
continue;


The patch was carelessly prepared, was not runtine-tested and was not
passed through checkpatch, which detects this error. Please fix these
things, permanently.

Yes, you're right, I definitely need to change my workflow, this needn't happen.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/