Re: [PATCH 24/27] NFS: Use local caching [try #2]

From: Trond Myklebust
Date: Wed Jan 30 2008 - 01:46:56 EST



On Wed, 2008-01-30 at 03:25 +0000, David Howells wrote:
> Chuck Lever <chuck.lever@xxxxxxxxxx> wrote:
>
> > This patch really ought to be broken into more manageable atomic
> > changes to make it easier to review, and to provide more fine-grained
> > explanation and rationalization for each specific change via
> > individual patch descriptions.
>
> Hmmm.... I broke the patch up as Trond stipulated - at least, I thought I
> had.
>
> In many ways this request doesn't make sense. You can't do NFS caching
> without all the appropriate bits, so logically they should be one patch.
> Breaking it up won't help git-bisect since the option to enable all this is
> the last (or nearly last) patch.

That depends entirely on what you are tracking. At this point in time,
I'm completely uninterested in debugging cachefs, but _very_ interested
in tracking and debugging changes to core NFS code.

Trond
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/