Re: [PATCH 076/196] ecryptfs: remove version_str file from sysfs

[Jeff Garzik]

Greg Kroah-Hartman wrote:
> This file violates the one-value-per-file sysfs rule.
>
> If you all want it added back, please do something like a per-feature
> file to show what is present and what isn't.
>
> Cc: Kay Sievers <kay.sievers@xxxxxxxx>
> Cc: Mike Halcrow <mhalcrow@xxxxxxxxxx>
> Cc: Phillip Hellewell <phillip@xxxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxx>
> ---
>  fs/ecryptfs/main.c |   43 -------------------------------------------
>  1 files changed, 0 insertions(+), 43 deletions(-)

It's not really good policy to rip out ABIs found in release kernels 
like this, even if the motivation is sound.

IMO "don't break ABIs" rule is far more important than a 
one-value-per-file sysfs rule.

	Jeff



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/