Re: [PATCH 01/20 -v5] printk - dont wakeup klogd with interruptsdisabled

[Daniel Walker]

> 	if (wake_klogd && !runqueue_is_locked())
> 		wake_up_klogd();
> 
> This probably is the cleanest solution since it simply prevents the
> deadlock from occurring.

Do you really need to call it with the runqueue lock held .. There are
other issue with the calls at that level.. For instance in -rt these
call can actually hang the system in the console laying from inside
printk (something I reported more than 6 months ago) .. It would be
better to move them around the scheduler rather than inside it..

Daniel

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/