Re: [PATCH] Remove BKL from sysctl(2)

[Andi Kleen]

Alan Cox <alan@xxxxxxxxxxxxxxxxxxx> writes:
> 
> There are cases that updating the corepath name and dumping a core at the
> same moment can result in the wrong thing being exec()'d or a file being
> opened which is a mix of the old and new name and could go anywhere.
> 
> I see two variants on your patch that work
> 
> #1	Replace the lock_kernel with a sysctl_update mutex and fix both
> paths
> #2	Add locking specifically to the corename path

Doesn't that apply to pretty much all proc_dostring users, not just
corename? 

Some of them might be already broken if their readers don't take BKL.
Also possibly some of the proc_dointvec for multiple numbers.

-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/