Re: 2.6.24-rc8-mm1 : net tcp_input.c warnings

From: Ilpo Järvinen
Date: Wed Jan 23 2008 - 02:41:45 EST


On Tue, 22 Jan 2008, David Miller wrote:

> From: "Dave Young" <hidave.darkstar@xxxxxxxxx>
> Date: Wed, 23 Jan 2008 09:44:30 +0800
>
> > On Jan 22, 2008 6:47 PM, Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxx> wrote:
> > > [PATCH] [TCP]: debug S+L
> >
> > Thanks, If there's new findings I will let you know.
>
> Thanks for helping with this bug Dave.

I noticed btw that there thing might (is likely to) spuriously trigger at
WARN_ON(sacked != tp->sacked_out); because those won't be equal when SACK
is not enabled. If that does happen too often, I send a fixed patch for
it, yet, the fact that I print print tp->rx_opt.sack_ok allows
identification of those cases already as it's zero when SACK is not
enabled.

Just ask if you need the updated debug patch.

--
i.