Re: [PATCH 7/7] driver-core : convert semaphore to mutex in struct class

From: Dave Young
Date: Mon Jan 21 2008 - 03:45:05 EST


On Jan 21, 2008 4:36 PM, Jarek Poplawski <jarkao2@xxxxxxxxx> wrote:
> On Mon, Jan 21, 2008 at 09:43:35AM +0800, Dave Young wrote:
> ...
> > Convert the class semaphore to mutex.
> > class_interface_register/unregister use class_device_* functions, so SINGLE_DEPTH_NESTING added for lockdep please in these functions.
>
> Looks fine to me now, but... I think you forgot again to make it
> clear that there were no lockdep warnings observed after this patch.
> And it seems there should be used something more complex than usb
> mouse or modem to verify this. Then IMHO it would be very nice if
> Andrew dares to merge this to -mm...

I applied it in my kernel, built and run without warnings, but it need
more testing.
I will be very glad to see the test result about this if you could, thanks.

>
> Regards,
> Jarek P.
>
> PS: I miss a lot function names in this patch...
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/