Re: [PATCH] x86: Construct 32 bit boot time page tables in nativeformat.

[H. Peter Anvin]

Andi Kleen wrote:
> > > There are various loaders (kexec, elilo, ...) that skip the 16bit code
> > > and jump directly to 32bit head.S. So in theory those could hit it.
> > > But still having the loop only is probably fine.
> > It's probably just as well, since we don't really know how to get a 
> > message out in such an environment anyway...
>
> It would be robably possible to extend the 32bit protocol to some
> way to error out in such a case. On the other hand I'm not sure it's really
> worth the considerable work to implement and debug such an addition.
>
> > > > variant of make_pte now though.
> > > The 32bit cast still feels unclean. After all the PTE is not 32bit.
> > No, but (pte_t *) is 32 bits.  To be more "Linuxy" it probably should be 
> > (long) or (unsigned long) though.
>
> That's not 32bit either.

Looked at the subject line?

	-hpa

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/