Re: [patch 1/3] LatencyTOP infrastructure patch

From: Helge Deller
Date: Sun Jan 20 2008 - 06:35:25 EST


Arjan van de Ven wrote:
> [linux-2.6.24-rc7/include/linux/latencytop.h]
> +struct latency_entry {
> + char *reason;
>...
> +struct latency_record {
> + char *reason;
>...
> +struct latency_entry *set_latency_reason(char *reason,
>...

I'd propose to mark the "reason" entries above (and the others as well)
as "const char *", which would move the strings to the ro-data section.

Helge

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/