Re: [PATCH 5/5] x86: Add debug of invalid per_cpu map accesses

From: Christoph Lameter
Date: Fri Jan 18 2008 - 13:56:53 EST


On Fri, 18 Jan 2008, Andi Kleen wrote:

> On Friday 18 January 2008 19:30:16 travis@xxxxxxx wrote:
> > Provide a means to trap usages of per_cpu map variables before
> > they are setup. Define CONFIG_DEBUG_PER_CPU_MAPS to activate.
>
> Are you sure that debug option is generally useful enough
> to merge? It seems very specific to your patchkit, but I'm not
> sure it would be worth carrying forever in the kernel.
>
> Better would be probably to just unmap those areas anyways.

Its generally useful also for the cpu_alloc changes that may lead
to the moving around of early initialization code for consolidation of
code between i386 and x86_64 once Mike's initial patchset is in.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/