Re: [PATCH 1/2] x86: add is_f00f_bug helper to fault_32|64.c

From: Ingo Molnar
Date: Fri Jan 18 2008 - 04:10:22 EST



* Andi Kleen <andi@xxxxxxxxxxxxxx> wrote:

> Harvey Harrison <harvey.harrison@xxxxxxxxx> writes:
>
> > Further towards unifying these files, add another helper in same
> > spirit as is_errata93.
>
> The better way to handle this would be to move all these workarounds
> into notifiers that only get registered on the CPUs that actually have
> the bugs.
>
> There is right now no die notifier in the right place for this, but
> you could just add one there. This is no performance critical place.

agreed in principle, but i think it's perhaps a bit more maintainable if
we first aimed for unification, then did such cleanups ontop of the
unified code. Almost everything we do prior unification is double the
work.

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/