Re: [mm patch] i915: fix invalid opcode exception on cpus withoutclflush

From: Kyle McMartin
Date: Thu Jan 17 2008 - 21:31:25 EST


On Thu, Jan 17, 2008 at 09:03:17PM -0500, H. Peter Anvin wrote:
> The #ifdef is bogus. If it's required, it should go into
> asm-x86/required_features.h and then cpu_has_clflush is static; otherwise
> it's just plain wrong.
>

I have no objection to making cpu_has_clflush constant on x86_64. The
point was to get rid of a needless test & branch on 64-bit, and making
it constant will have the same effect.

cheers, Kyle
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/