Re: [PATCH] fix wrong sized spinlock flags argument

From: Daniel Walker
Date: Thu Jan 17 2008 - 19:08:28 EST



On Thu, 2008-01-17 at 15:48 -0800, Linus Torvalds wrote:
> Applied.
>
> However, the patch itself didn't apply cleanly, because in my souce tree,
> these two lines are in a different order:
>
> On Thu, 17 Jan 2008, Daniel Walker wrote:
> >
> > pci_set_power_state(pci_dev, PCI_D0);
> > pci_restore_state(pci_dev);
>
> but I actually think your order is the *correct* one (because I'm not at
> all sure that config space writes are even guaranteed to make a difference
> when in D3cold).

I was actually using 2.6.24-rc8-mm1 . The code looked similar enough,
but I must have overlooked the fact that the lines above got switched..

Daniel

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/