Re: [PATCH] x86: copy srat table and unmap in acpi_parse_table

From: Ingo Molnar
Date: Thu Jan 17 2008 - 17:07:00 EST



* Yinghai Lu <Yinghai.Lu@xxxxxxx> wrote:

> > Or if d8d28f25f33c6a03 really needs to be reverted to get your
> > system to boot properly, which particular bit of it was causing
> > trouble for you? (or the whole thing?)
>
> we need to call acpi_os_unmap_memory in acpi_table_parse or just after
> it.
>
> call it in acpi_table_parse is much cleaner

agreed - i had a second look at your patch and it's much cleaner.

> the problem is that acpi_numa_slit_init do bad assumaption that it
> still can use address after it's callback function. so we need to copy
> the slit.

ok. I've applied your patch and boot-tested it already - it should show
up soon in the next x86.git drop.

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/