Re: [PATCH 1/4] RT: remove duplicate time/Kconfig

From: Frank Rowand
Date: Wed Jan 16 2008 - 21:12:42 EST



On Wed, 2008-01-16 at 20:29 -0500, Steven Rostedt wrote:
> On Wed, 16 Jan 2008, Frank Rowand wrote:
>
> >
> > time/Kconfig added by preempt-realtime-mips.patch duplicates other entry,
> > resulting in kernel make error:
> >
> > Signed-off-by: Frank Rowand <frank.rowand@xxxxxxxxxxx>
> > ---
> > arch/mips/Kconfig | 2 0 + 2 - 0 !
> > 1 files changed, 2 deletions(-)
> >
> > Index: linux-2.6.24-rc7/arch/mips/Kconfig
> > ===================================================================
> > --- linux-2.6.24-rc7.orig/arch/mips/Kconfig
> > +++ linux-2.6.24-rc7/arch/mips/Kconfig
> > @@ -1001,8 +1001,6 @@ config BOOT_ELF64
> >
> > menu "CPU selection"
> >
> > -source "kernel/time/Kconfig"
> > -
> > choice
> > prompt "CPU type"
> > default CPU_R4X00
>
> heh, This doesn't apply either. Or is this to be done before the patches
> are added?

Hmmm, I don't seem to be doing to well here. It was created after the
-rt3 patch was applied. Thanks for you patience with me here!!

>
> Anyway, I did find the two konfig references:
>
> ...
>
> This is purely to save memory - each supported CPU adds
> approximately eight kilobytes to the kernel image. For best
> performance should round up your number of processors to the next
> power of two.
>
> source "kernel/time/Kconfig"
>
> #
> # Timer Interrupt Frequency Configuration
> #
>
> ...
>
> config GENERIC_TIME
> bool
> default y
>
> source "kernel/time/Kconfig"
>
> config CPU_SPEED
> int "CPU speed used for clocksource/clockevent calculations"
> default 600
> endmenu
>
> ...
>
>
> I'll apply your patch in quilt and then make the proper change. Which
> Kconfig do you want gone?

It would be good to get rid of the first one, but I'm especially picky.


>
> -- Steve
>
>


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/