Re: [PATCH -mm 0/3] i386 boot: replace boot_ioremap with enhancedbt_ioremap

From: H. Peter Anvin
Date: Tue Jan 15 2008 - 07:58:44 EST


Huang, Ying wrote:

After checking the early_ioremap() implementation in
arch/x86/kernel/setup_32.c, I found that it is a duplication of
bt_ioremap() implementation in arch/x86/mm/ioremap_32.c. Both
implementations use set_fixmap(), so they can be used only after
paging_init().

The early_ioremap implementation provided in this patchset works as
follow:

- Enhances bt_ioremap, make it usable before paging_init() via a
dedicated PTE page.
- Rename bt_ioremap to early_ioremap

So I think maybe we should replace the early_ioremap() implementation in
PAT series with that of this series.


I did a quick scan over the patchset (not quite awake yet, so I may very well have missed something), but it looks like EFI (again!) is the only user of ioremapping before paging_init(). This makes me wonder if that code can't be restructured so that isn't necessary.

-hpa

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/