Re: [PATCH/RFC] synchronize_rcu(): high latency on idle system

From: Benjamin LaHaise
Date: Sat Jan 12 2008 - 12:52:05 EST


On Sat, Jan 12, 2008 at 03:37:59AM +0100, Andi Kleen wrote:
> > And yes, the
> > network stack shouldn't call synchronize_rcu() quite so much, but fixing that
> > is a little more involved.
>
> ... but the correct solution.

There has to be at least 1 synchronize_rcu() or equivalent in the
unregister_netdev() path. I suspect the easiest way to fix it might be to
use call_rcu() to actually free the network device, as anything else will
limit performance of single threaded teardown (ie, when an l2tp daemon
gets terminated via kill -9). This means an API change that exposes
rcu for unregister_netdev().

-ben
--
"Time is of no importance, Mr. President, only life is important."
Don't Email: <zyntrop@xxxxxxxxx>.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/