Re: [PATCH x86] [15/16] Force __cpuinit on for CONFIG_PM without HOTPLUG_CPU

From: Rafael J. Wysocki
Date: Thu Jan 10 2008 - 12:15:05 EST


On Thursday, 10 of January 2008, Andi Kleen wrote:
> On Thursday 10 January 2008 12:26:07 Adrian Bunk wrote:
> > On Thu, Jan 10, 2008 at 12:15:15PM +0100, Andi Kleen wrote:
> > > > But your patch does:
> > > >
> > > > +config PM_CPUINIT
> > > > + bool
> > > > + depends on PM
> > >
> > > That is because arch/x86/power/cpu.c where this happens is currently
> > >
> > > obj-$(CONFIG_PM) += cpu.o
> > >
> > > If it was changed to CONFIG_something else then yes that dependency
> > > should be changed too.
> >
> >
> > Then fix this first.
>
> Rafael indicated he would do that,

Yes, and I'm still going to do that. :-)

Thanks,
Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/