Re: [PATCH] x86: Remove ifdef from step.c

From: Ingo Molnar
Date: Thu Jan 10 2008 - 07:41:01 EST



* Harvey Harrison <harvey.harrison@xxxxxxxxx> wrote:

> @@ -148,11 +148,7 @@ static void write_debugctlmsr(struct task_struct *child, unsigned long val)
> if (child != current)
> return;
>
> -#ifdef CONFIG_X86_64
> - wrmsrl(MSR_IA32_DEBUGCTLMSR, val);
> -#else
> wrmsr(MSR_IA32_DEBUGCTLMSR, val, 0);
> -#endif

doesnt this break 64-bit? 'val' is 64-bit, but wrmsr truncates it to
32-bit? [while wrmsrl() kept the full 64 bits]

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/