Re: [PATCH] x86_64: enable irq in default_idle

From: Ingo Molnar
Date: Tue Jan 08 2008 - 17:13:10 EST



* Hiroshi Shimamoto <h-shimamoto@xxxxxxxxxxxxx> wrote:

> >> local_irq_enable() is missing after
> >> sched_clock_idle_wakeup_event().
> >
> > thanks Hiroshi, applied.
> >
> > The effects of this bug should be increased latencies on 64-bit. Did
> > you notice these latencies, or did you find the bug in some other
> > way (code review)?
>
> I found this when I was comparing 32-bit and 64-bit source code for
> x86 unification.

cool :) Indeed even for other code, a number of times we got bugfixes
when unifying 32-bit and 64-bit files.

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/