Re: [PATCH 2/3] pci: Remove users of pci_enable_device_bars()

From: Andrew Vasquez
Date: Mon Jan 07 2008 - 14:42:42 EST


On Thu, 20 Dec 2007, Benjamin Herrenschmidt wrote:

> This patch converts users of pci_enable_device_bars() to the new
> pci_enable_device_{io,mem} interface.
>
> The new API fits nicely, except maybe for the QLA case where a bit of
> code re-organization might be a good idea but I prefer sticking to the
> simple patch as I don't have hardware to test on.

That's fine. I take it these patches will be funneled via
gregkh/pci-2.6.git. There's some qla2xxx updates which are queued for
post-2.6.24 consumption in jejb/scsi-misc-2.6.git which don't appear
to have any conflicts.

I do though have a series of patches which I'll hold off on submitting
to linux-scsi until these PCI changes are merged, as there's some
minor conflicts merging the three branches. James B, will that be
fine?

The patches themselves appear to be working fine within several of our
test rings. I hold off on some of the cleanup post-merge time...

Thanks,
Andrew Vasquez

> Signed-off-by: Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx>
> ---
>
> drivers/ata/pata_cs5520.c | 2 +-
> drivers/i2c/busses/scx200_acb.c | 2 +-
> drivers/ide/pci/cs5520.c | 10 ++++++++--
> drivers/ide/setup-pci.c | 6 ++++--
> drivers/scsi/lpfc/lpfc_init.c | 3 +--
> drivers/scsi/qla2xxx/qla_os.c | 12 +++++++++---

Acked-by: Andrew Vasquez <andrew.vasquez@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/