Re: [PATCH 24/24] udf: fix sparse warnings (shadowing & mismatchbetween declaration and definition)

[Jan Kara]

On Sun 23-12-07 02:51:14, marcin.slusarz@xxxxxxxxx wrote:
> fix warnings:
> fs/udf/super.c:1370:24: warning: symbol 'bh' shadows an earlier one
> fs/udf/super.c:1288:21: originally declared here
> fs/udf/super.c:450:6: warning: symbol 'udf_write_super' was not declared. Should it be static?
> 
> Signed-off-by: Marcin Slusarz <marcin.slusarz@xxxxxxxxx>
> CC: Ben Fennema <bfennema@xxxxxxxxxxxxxxxxxxxxxx>
> CC: Jan Kara <jack@xxxxxxx>
  Looks fine. Acked-by: Jan Kara <jack@xxxxxxx>

											Honza

> ---
>  fs/udf/super.c |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/udf/super.c b/fs/udf/super.c
> index f6c911b..da68130 100644
> --- a/fs/udf/super.c
> +++ b/fs/udf/super.c
> @@ -447,7 +447,7 @@ static int udf_parse_options(char *options, struct udf_options *uopt)
>  	return 1;
>  }
>  
> -void udf_write_super(struct super_block *sb)
> +static void udf_write_super(struct super_block *sb)
>  {
>  	lock_kernel();
>  
> @@ -1367,7 +1367,6 @@ static int udf_load_partition(struct super_block *sb, kernel_lb_addr *fileset)
>  				map->s_type_specific.s_virtual.s_num_entries =
>  					(udf_sb_vat_inode(sb)->i_size - 36) >> 2;
>  			} else if (map->s_partition_type == UDF_VIRTUAL_MAP20) {
> -				struct buffer_head *bh = NULL;
>  				uint32_t pos;
>  
>  				pos = udf_block_map(udf_sb_vat_inode(sb), 0);
> -- 
> 1.5.3.4
> 
-- 
Jan Kara <jack@xxxxxxx>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/