Re: [patch 1/3] move WARN_ON() out of line

From: Herbert Xu
Date: Fri Jan 04 2008 - 21:35:47 EST


Arjan van de Ven <arjan@xxxxxxxxxxxxxxx> wrote:
>
>> While we're here, I'll mention that dump_stack probably ought to take a
>> severity level argument.
>
> 125 files changed, 202 insertions(+), 199 deletions(-)
> just to get the api change done.
> I can hear akpm cringe from here...

You don't have to change all of them at once. Just create a new function
that does take a level and make the old dump_stack and WARN_ON call that
then slowly convert everything else across if so desired.

Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/