Re: [PATCH] profile: further Codying Style fixes, take 2

[Paolo Ciarrocchi]

On Jan 4, 2008 9:37 PM, Sam Ravnborg <sam@xxxxxxxxxxxx> wrote:
> On Fri, Jan 04, 2008 at 06:52:09PM +0100, Paolo Ciarrocchi wrote:
> > Further fixes to profile.c, checkpatch.pl now reports:
> >
> >       total: 0 errors, 2 warnings, 601 lines checked
> >
> >   WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
> >   #410: FILE: profile.c:410:
> >   +EXPORT_SYMBOL_GPL(profile_hits);
> > I cannot fix this without changing the funtionality in case of non-SMP build.
>
> If you look a bit more you will see two functions named
> profile_hits.
> So you just add the export twice - like this:
> diff --git a/kernel/profile.c b/kernel/profile.c
> index 5e95330..fc4570d 100644
> --- a/kernel/profile.c
> +++ b/kernel/profile.c
> @@ -337,6 +337,7 @@ out:
>         local_irq_restore(flags);
>         put_cpu();
>  }
> +EXPORT_SYMBOL_GPL(profile_hits);
>
>  static int __devinit profile_cpu_callback(struct notifier_block *info,
>                                         unsigned long action, void *__cpu)
> @@ -408,9 +409,8 @@ void profile_hits(int type, void *__pc, unsigned int nr_hits)
>         pc = ((unsigned long)__pc - (unsigned long)_stext) >> prof_shift;
>         atomic_add(nr_hits, &prof_buffer[min(pc, prof_len - 1)]);
>  }
> -#endif /* !CONFIG_SMP */
> -
>  EXPORT_SYMBOL_GPL(profile_hits);
> +#endif /* !CONFIG_SMP */
>
>  void profile_tick(int type)
>  {
>
> Which has the added benefit that it is now documented for
> both implementations that they are exported.

Nice, thanks for the explanation Sam.

> >
> >
> >   WARNING: externs should be avoided in .c files
> >   #509: FILE: profile.c:509:
> >   +       extern int setup_profiling_timer(unsigned int multiplier);
> > I don't know what to do with this warning.
>
> Stick the prototype in profile.h maybe?
> I can see that not all implementers of this function
> includes profile.h so it is not foolproof.

That would not be an easy fix for me (I'm almost new to these things),
I can try to that but I would appreciated if Ingo could apply the patch
as it is now and wait a bit for the further fix.

Ingo, do you agree?


Ciao,
-- 
Paolo
http://paolo.ciarrocchi.googlepages.com/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/