RE: [PATCH 3/4] async_tx: replace 'int_en' with operation preparationflags

From: Nelson, Shannon
Date: Fri Jan 04 2008 - 16:47:48 EST


>From: Williams, Dan J
>
>Pass a full set of flags to drivers' per-operation 'prep' routines.
>Currently the only flag passed is DMA_PREP_INTERRUPT. The
>expectation is
>that arch-specific async_tx_find_channel() implementations can
>exploit this
>capability to find the best channel for an operation.
>
>Signed-off-by: Dan Williams <dan.j.williams@xxxxxxxxx>
>---
>
> crypto/async_tx/async_memcpy.c | 3 ++-
> crypto/async_tx/async_memset.c | 3 ++-
> crypto/async_tx/async_xor.c | 10 ++++++----
> drivers/dma/ioat_dma.c | 4 ++--
> drivers/dma/iop-adma.c | 20 ++++++++++----------
> include/asm-arm/arch-iop13xx/adma.h | 18 ++++++++++--------
> include/asm-arm/hardware/iop3xx-adma.h | 30
>+++++++++++++++++-------------
> include/linux/dmaengine.h | 17 +++++++++++++----
> 8 files changed, 62 insertions(+), 43 deletions(-)


Yep - this is good. This will allow us to add an interrupt request flag
to the transaction request in the future.

Acked by: Shannon Nelson <shannon.nelson@xxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/