Re: [patch 2/2] Add the end-of-trace marker and the module list toWARN_ON()

From: Ingo Molnar
Date: Fri Jan 04 2008 - 05:43:47 EST



* Arjan van de Ven <arjan@xxxxxxxxxxxxxxx> wrote:

> Ingo Molnar wrote:
>> * Arjan van de Ven <arjan@xxxxxxxxxxxxxxx> wrote:
>>
>>> + printk(KERN_WARNING "------------[ cut here ]------------\n");
>>> printk(KERN_WARNING "WARNING: at %s:%d %s()\n", file,
>>> line, function);
>>> + print_modules();
>>> dump_stack();
>>> + print_oops_end_marker();
>>
>> another thing: could we also put the marker into dump_stack(), and attach
>> the marker to the Call Trace line?
>
> I have a preliminary patch for that already but I'm not happy with it
> yet; I need to redo it properly. It's neither depending nor
> incremental to these 2 patches though..

yeah, it was a sidenote - it should be separate to these two patches.

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/