Re: [PATCH] md: Fix data corruption when a degraded raid5 array isreshaped.

From: Neil Brown
Date: Thu Jan 03 2008 - 19:42:23 EST


On Thursday January 3, dan.j.williams@xxxxxxxxx wrote:
>
> On closer look the safer test is:
>
> !test_bit(STRIPE_OP_COMPUTE_BLK, &sh->ops.pending).
>
> The 'req_compute' field only indicates that a 'compute_block' operation
> was requested during this pass through handle_stripe so that we can
> issue a linked chain of asynchronous operations.
>
> ---
>
> From: Neil Brown <neilb@xxxxxxx>

Technically that should probably be
From: Dan Williams <dan.j.williams@xxxxxxxxx>

now, and then I add
Acked-by: NeilBrown <neilb@xxxxxxx>

because I completely agree with your improvement.

We should keep an eye out for then Andrew commits this and make sure
the right patch goes in...

Thanks,
NeilBrown

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/