Re: [x86] kernel/audit.c cleanup according to checkpatch.pl

[David Woodhouse]

On Thu, 2008-01-03 at 15:37 +0100, Ingo Molnar wrote:
> * David Woodhouse <dwmw2@xxxxxxxxxxxxx> wrote:
> 
> > On Thu, 2008-01-03 at 15:05 +0100, Ingo Molnar wrote:
> > > not to make a big issue out of this, but when was the last time you 
> > > tried to grep this way:
> > > 
> > >   grep -E "audit_rate_limit=[0-9]+ audit_backlog" */*.c
> > 
> > Not precisely that, but I've certainly had greps fail because people 
> > have split up strings to meet the stupid 80-character "limit".
> 
> yes - but if you read my whole reply you'll see that i qualified it:
> 
> >> That's pretty much the only grep pattern that would break. People 
> >> usually grep on the constant portion of the string, so breaking up a 
> >>                                                       ^^^^^^^^^^^^^
> >> line along a variable boundary is perfectly okay.

Yes, you did. But you failed to provide any good reason for actually
changing it, either. Leave it as it was.

-- 
dwmw2

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/