Re: [PATCH] [1/20] x86: Make ptrace.h safe to include from assembler code

[Andi Kleen]

On Thursday 03 January 2008 10:54:52 Ingo Molnar wrote:
> 
> * Andi Kleen <ak@xxxxxxx> wrote:
> 
> > Index: linux/include/asm-x86/ptrace-abi.h
> > ===================================================================
> > --- linux.orig/include/asm-x86/ptrace-abi.h
> > +++ linux/include/asm-x86/ptrace-abi.h
> > @@ -80,6 +80,7 @@
> >  
> >  #define PTRACE_SINGLEBLOCK	33	/* resume execution until next branch */
> >  
> > +#ifndef __ASSEMBLY__
> 
> hm, this patch misses a rationale - what assembly code includes 
> ptrace-abi.h directly or indirectly? Did you see any build breakage with 
> x86.git that requires this? (if yes then please send me the .config)

It's needed for the dwarf2 unwinder, but imho useful on its own.

-Andi


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/