Re: PATCH] adding wistron_btns support for X86_64 systems.

From: Rémi Hérilier
Date: Wed Jan 02 2008 - 19:37:46 EST


Carlos Corbacho wrote:
> (CC'ing linux-input, as that is the relevant subsystem list for wistron-btns).
>
> Rémi Hérilier wrote:
>> To use my previous patch (wistron_btns support for fujitsu-siemens amilo
>> pro edition v3505) with my laptop, I need to make the wistron module
>> compile for x86_64. It is based on Linux 2.4.24-rc4 too.
>
> NAK.
>
> You cannot make 32 bit BIOS calls in a 64 bit OS.
>
> This will (and does) segfault on x86-64 (tested on my Aspire 5020, where
> call_bios wistron-btns just segfaults on x86-64 with this patch).
>
> This is a known issue, and the reason why wistron-btns (and the out-of-tree
> acerhk) have not been ported to x86-64.
>
> -Carlos

Yes, in theory, this must segfault on x86-64.

In pratice, there is one laptop where it seems to works (no problem
for 3 weeks). A good reason to find why.


Best regards

Remi Herilier
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/