Re: [2.6.24 patch] let EXT4DEV_FS depend on BROKEN

[Adrian Bunk]

On Wed, Jan 02, 2008 at 10:41:57AM -0700, Andreas Dilger wrote:
> On Jan 02, 2008  03:32 +0200, Adrian Bunk wrote:
> > It might make sense to offer ext4 in -mm and even in early -rc kernels, 
> > but I've already seen people using ext4 simply because a stable kernel 
> > offered it - and that's definitely not intended.
> > 
> > Anyone who _really_ wants to test ext4 should anyway be able to do the 
> > trivial change of removing the "depends on BROKEN" line.
> > 
> > Signed-off-by: Adrian Bunk <bunk@xxxxxxxxxx>
> > 
> > @@ -138,7 +138,7 @@ config EXT3_FS_SECURITY
> >  
> >  config EXT4DEV_FS
> >  	tristate "Ext4dev/ext4 extended fs support development (EXPERIMENTAL)"
> > -	depends on EXPERIMENTAL
> > +	depends on BROKEN
> >  	select JBD2
> >  	select CRC16
> >  	help
> 
> Isn't CONFIG_EXPERIMENTAL enough?

Most people and all distributions use CONFIG_EXPERIMENTAL=y simply 
because too many options (including options required for hardware 
support) depend on it.

Compare e.g.:
- "Marvell SATA support (HIGHLY EXPERIMENTAL)"
- "Provide NFSv4 client support (EXPERIMENTAL)"
- "Ext4dev/ext4 extended fs support development (EXPERIMENTAL)"

And I really do not have the impression that ext4 is ready for being 
used by people who cannot remove this depends line from a Kconfig file
in their kernel.

> Cheers, Andreas

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/