Re: [PATCH] x86: provide a DMI based port 0x80 I/O delay override.

[Rene Herman]

On 02-01-08 14:47, Alan Cox wrote:

> > ok, you are right. How about we go with one of your suggestions: rename 
> > the API family to isa_*_p() in the affected ISA drivers? That makes it 
> > perfectly clear that this is an ISA related historic quirk that we just 
> > cannot properly emulate in an acceptable fashion. It will also make the 
> > least amount of changes to these truly historic drivers.
>
> Works for me. We need to build two versions of 8390.c now but thats no
> big deal and sorts PCMCIA out too.

For no binary changes at all, and if going through all those outb_p() users 
anyway, might/could as well just manually split them then:

outb_p() --> outb();
             slow_down_io();

and then just leave out the slow_down_io() call in the non-ISA spots. 
slow_down_io() could be renamed isa_io_delay() or anything (paravirt is a 
little annoying there) if someone cares but then it's a complete identity 
transformation for any driver that does care.

Would IMO also make for a somewhat better API than an isa_outb_p() as 
there's nothing particurly ISA about the outb method itself -- many ISA 
drivers use plain outb() as well.

Rene.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/