Re: [patch] linux/ufs_fs.h: do not export to userspace anymore

From: Mike Frysinger
Date: Wed Jan 02 2008 - 08:41:18 EST


On Wednesday 02 January 2008, David Miller wrote:
> From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
> > The only non-kernel user of this known to me is silo, which should just
> > have it's own header documenting the solaris sparc ufs variant it needs
> > to understand, possibly by using a copy of the kernel version at any
> > given point of time.
>
> And this is what the current SILO sources do.

then if silo has gotten its stuff together ...
---
Do not export linux/ufs_fs.h to userspace anymore as the only userspace
consumer has been fixed to not need it anymore.

Signed-off-by: Mike Frysinger <vapier@xxxxxxxxxx>
---
diff --git a/include/linux/Kbuild b/include/linux/Kbuild
index f30fa92..fd2570f 100644
--- a/include/linux/Kbuild
+++ b/include/linux/Kbuild
@@ -336,7 +336,6 @@ unifdef-y += tty.h
unifdef-y += types.h
unifdef-y += udf_fs_i.h
unifdef-y += udp.h
-unifdef-y += ufs_fs.h
unifdef-y += uinput.h
unifdef-y += uio.h
unifdef-y += unistd.h
diff --git a/include/linux/ufs_fs.h b/include/linux/ufs_fs.h
index 10b854d..46e4a8d 100644
--- a/include/linux/ufs_fs.h
+++ b/include/linux/ufs_fs.h
@@ -35,16 +35,10 @@
#include <linux/stat.h>
#include <linux/fs.h>

-#ifndef __KERNEL__
-typedef __u64 __fs64;
-typedef __u32 __fs32;
-typedef __u16 __fs16;
-#else
#include <asm/div64.h>
typedef __u64 __bitwise __fs64;
typedef __u32 __bitwise __fs32;
typedef __u16 __bitwise __fs16;
-#endif

#define UFS_BBLOCK 0
#define UFS_BBSIZE 8192
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/