Re: [PATCH linux-acpi] Correct wakeup set error and append a new column PCI ID

[Pavel Machek]

Hi!

> /proc/acpi/wakeup is also case-sensitive, case-insensitive is better.

Why?

> In addtion, this patch appends a new column 'PCI ID' to /proc/acpi/wakeup
> , the user can use it to get the corresponding device name very
> conveniently because PCI ID is a unique identifier and platform-independent.

Userland interface change...?

Maybe this file should be left for compatibility and we should present
something reasonable in /sys? Can't you already get PCI ID from sysfs
node?
								Pavel

> [root@localhost ~]# cat /proc/acpi/wakeup
> Device  S-state   Status   Sysfs node
> C093      S5     disabled  pci:0000:00:1e.0
> C0E8      S3     disabled  pci:0000:00:1d.0
> C0EF      S3     disabled  pci:0000:00:1d.1
> C0F0      S3     disabled  pci:0000:00:1d.2
> C0F1      S3     disabled  pci:0000:00:1d.3
> C0F2      S3     disabled  pci:0000:00:1d.7
> C0F9      S0     disabled  pci:0000:00:1c.0
> C21D      S0     disabled  pci:0000:08:00.0
> C109      S5     disabled  pci:0000:00:1c.1
> C228      S5     disabled  pci:0000:10:00.0
> C10F      S5     disabled  pci:0000:00:1c.3
> C229      S5     disabled
> [root@localhost ~]#
> 
> After applying this patch, the output is:
> 
> [root@localhost ~]# cat /proc/acpi/wakeup
> Device  S-state   Status   Sysfs node           PCI ID
> C093      S5     disabled  pci:0000:00:1e.0     0x2448
> C0E8      S3     disabled  pci:0000:00:1d.0     0x27c8
> C0EF      S3     disabled  pci:0000:00:1d.1     0x27c9
> C0F0      S3     disabled  pci:0000:00:1d.2     0x27ca
> C0F1      S3     disabled  pci:0000:00:1d.3     0x27cb
> C0F2      S3     disabled  pci:0000:00:1d.7     0x27cc
> C0F9      S0     disabled  pci:0000:00:1c.0     0x27d0
> C21D      S0     disabled  pci:0000:08:00.0     0x16fd
> C109      S5     disabled  pci:0000:00:1c.1     0x27d2
> C228      S5     disabled  pci:0000:10:00.0     0x4222
> C10F      S5     disabled  pci:0000:00:1c.3     0x27d6
> C229      S5     disabled

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/