Re: [PATCH - RFC] x86: unify arch/x86/kernel/Makefile(s)

From: Ingo Molnar
Date: Sun Dec 30 2007 - 09:55:50 EST



* Sam Ravnborg <sam@xxxxxxxxxxxx> wrote:

> Combine the 32 and 64 bit specific Makefiles in one file. While doing
> so link order was (almost) preserved on 32 bit but on 64 bit link
> order changed a lot.
>
> Patch was checked with defconfig + allyesconfig builds. The same .o
> files were linked in these configurations.
>
> To keep readability of the Makefiles a few Kconfig symbols was
> added/modified and it was checked that they were not used anywhere
> else.

hm, i agree with this change, but would it be possible to split this up
into gradual steps, to change the rules on 64-bit one by one? That would
make it much more bisectable. In our experience changes to the link
order have a high likelyhood of breaking stuff, as we've got so many
implicit initcall dependencies that are not explicitly spelled out.

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/