Re: [PATCH 1/1] mxser, remove it

From: Alan Cox
Date: Fri Dec 28 2007 - 21:32:58 EST


> >
> >+static int mxvar_baud_table[] = {
> >+ 0, 50, 75, 110, 134, 150, 200, 300, 600, 1200, 1800, 2400,
> >+ 4800, 9600, 19200, 38400, 57600, 115200, 230400, 460800, 921600
> >+};
> >+static unsigned int mxvar_baud_table1[] = {
> >+ 0, B50, B75, B110, B134, B150, B200, B300, B600, B1200, B1800, B2400,
> >+ B4800, B9600, B19200, B38400, B57600, B115200, B230400, B460800, B921600
> >+};
>
> Constify both, if possible?

These are not portable - baud rate tables vary for some platforms. No
driver should be touching Bxxx coding itself any more. Use the tty_
functions to decode and encode baud rates.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/