Re: [PATCH 1/1] mxser, remove it

From: Adrian Bunk
Date: Thu Dec 27 2007 - 12:50:50 EST


On Thu, Dec 27, 2007 at 06:19:31PM +0300, Michael Tokarev wrote:
> Jiri Slaby wrote:
> > (Old) mxser is obsoleted by mxser_new and scheduled for removal on Dec 2007.
> > Remove it.
> >
> > Signed-off-by: Jiri Slaby <jirislaby@xxxxxxxxx>
> > ---
> > Documentation/feature-removal-schedule.txt | 8 -
> > drivers/char/Kconfig | 11 -
> > drivers/char/Makefile | 1 -
> > drivers/char/mxser.c | 3141 ----------------------------
> > drivers/char/mxser.h | 441 ----
> > 5 files changed, 0 insertions(+), 3602 deletions(-)
> > delete mode 100644 drivers/char/mxser.c
> > delete mode 100644 drivers/char/mxser.h
>
> While we're at it, how about adding a modalias for mxser_new
> module with old (being removed) name, so that users who're
> using the old module will not scream? I mean, in order for
> `modprobe mxser' to load mxser_new module.

It might even make sense to rename the mxser_new module to mxser and do
it the other way round - it's e.g. not clear whether a _new driver is
for new hardware or a new driver for old hardware.

> /mjt

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/