Re: [PATCH] w1-gpio: Add GPIO w1 bus master driver

[Haavard Skinnemoen]

On Fri, 21 Dec 2007 09:34:01 +0200
Ville Syrjala <syrjala@xxxxxx> wrote:

> +static struct platform_device foo_w1_device = {
> +	.name			= "w1-gpio",
> +	.id			= -1,

Assigning -1 to a u32 member isn't a very nice example. What does it
mean anyway?

> +static int __init w1_gpio_probe(struct platform_device *pdev)

This must be __devinit, or if you want to save a bit of memory...

> +	.probe	= w1_gpio_probe,

...remove this line, and...

> +static int __init w1_gpio_init(void)
> +{
> +	return platform_driver_register(&w1_gpio_driver);

...call platform_driver_probe(&w1_gpio_driver, w1_gpio_probe) here.

Haavard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/