Re: [patch, rfc] mm.h, security.h, key.h and preventing namespacepoisoning

From: Andrew Morton
Date: Tue Dec 25 2007 - 17:07:13 EST


On Thu, 20 Dec 2007 15:11:40 +1100 (EST) James Morris <jmorris@xxxxxxxxx> wrote:

> > > +#ifdef CONFIG_SECURITY
> > > +extern unsigned long mmap_min_addr;
> > > +#endif
> > > +
> > > #include <asm/page.h>
> > > #include <asm/pgtable.h>
> > > #include <asm/processor.h>
> >
> > Fine by me.
>
> I'll queue it for -mm & 2.6.25.

I don't think we need the ifdef. If someone incorrectly refers to this
then they'll get a link-time error rather than a compile-time error (bad).
But we lose an ifdef (good).

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/