Re: [PATCH 15/38] drivers/infiniband: Use time_before, time_before_eq,etc.

[Julia Lawall]

On Tue, 25 Dec 2007, YOSHIFUJI Hideaki / µÈÆ£±ÑÌÀ wrote:

> In article <Pine.LNX.4.64.0712241528140.23999@xxxxxxxxxxx> (at Mon, 24 Dec 2007 15:28:42 +0100 (CET)), Julia Lawall <julia@xxxxxxx> says:
> 
> > diff -r -u -p a/drivers/infiniband/hw/ipath/ipath_mad.c b/drivers/infiniband/hw/ipath/ipath_mad.c
> > --- a/drivers/infiniband/hw/ipath/ipath_mad.c	2007-10-22 11:25:09.000000000 +0200
> > +++ b/drivers/infiniband/hw/ipath/ipath_mad.c	2007-12-23 20:35:37.000000000 +0100
> > @@ -1334,7 +1334,8 @@ static int process_subn(struct ib_device
> >  	}
> >  
> >  	/* Is the mkey in the process of expiring? */
> > -	if (dev->mkey_lease_timeout && jiffies >= dev->mkey_lease_timeout) {
> > +	if (dev->mkey_lease_timeout &&
> > +	    time_before_eq(jiffies, dev->mkey_lease_timeout)) {
> >  		/* Clear timeout and mkey protection field. */
> >  		dev->mkey_lease_timeout = 0;
> >  		dev->mkeyprot = 0;
> 
> time_after_eq()

I see that there are quite a lot of problems like this.  I will have to 
start over...

julia