Re: Linux 2.6.24-rc5 x86 architecture no longer Oopses...

From: Ingo Molnar
Date: Thu Dec 20 2007 - 19:06:23 EST



* Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:

> On Fri, 21 Dec 2007 00:47:59 +0100
> Ingo Molnar <mingo@xxxxxxx> wrote:
>
> > it needs to be found out why the preempt_count suddenly went to zero. Is
> > task struct corruption out of question?
>
> Strictly we shouldn't care - we _know_ we've already hit a kernel bug
> and who knows, perhaps that buggy code did an unbalanced
> preempt_disable(). So make the oops code more robust.
>
> otoh, we don't want to be hiding a bug. What piece of code guarantees
> that we ender the oops code with preemption disabled?

i looked at the patch you sent - and there the proof was in the sections
i quoted.

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/