Re: [PATCH 1/2] x86: fix kprobe_handler reenable preemption

From: Masami Hiramatsu
Date: Wed Dec 19 2007 - 11:05:30 EST


Hi Ingo,

Ingo Molnar wrote:
> * Masami Hiramatsu <mhiramat@xxxxxxxxxx> wrote:
>
>>> - return 1;
>>> + ret = 1;
>> Here, "return 1;" is correct. After single step is done, preemption is
>> enabled in post_kprobe_handler().
>
> could you resend the fixed patch? (instead of me fixing it up by hand -
> which is error-prone)

Sure, I'll resend asap.

>
> also, this seems like .24 material as well - could you send the fix
> against -rc5 too?

-rc tree is fine. Actually, it was introduced by my cleanup patch.
Thanks!

>
> Ingo

--
Masami Hiramatsu

Software Engineer
Hitachi Computer Products (America) Inc.
Software Solutions Division

e-mail: mhiramat@xxxxxxxxxx, masami.hiramatsu.pt@xxxxxxxxxxx


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/