Re: [PATCH v3 7/8] debugfs: allow access to signed values

From: Stefano Brivio
Date: Wed Dec 19 2007 - 04:25:42 EST


On Tue, 18 Dec 2007 22:45:10 -0800
Greg KH <gregkh@xxxxxxx> wrote:

> On Wed, Dec 19, 2007 at 01:27:39AM +0100, Stefano Brivio wrote:
> > Add debugfs_create_s{8,16,32,64}. For these to work properly, we need to remove
> > a cast in libfs.
> >
> > Cc: Johannes Berg <johannes@xxxxxxxxxxxxxxxx>
> > To: Greg Kroah-Hartman <gregkh@xxxxxxx>
> > Signed-off-by: Stefano Brivio <stefano.brivio@xxxxxxxxx>
> > ---
> > Greg,
> >
> > here comes an implementation of debugfs_create_s{8,16,32,64} which avoids code
> > duplication, suggested by Johannes Berg. We would need this to be merged to
> > 2.6.25, as we need those functions to be available for rc80211-pid, the new
> > mac80211 rate control algorithm.
>
> Looks good to me, do you want me to add this to my tree and send it to
> Linus when 2.6.25 opens up, or do you want this to go through the
> wireless tree as you have patches relying on it?

I have one patch (rate control rework, 8/8) relying on it. Let's ask John. John,
what's the best for you?

> Whatever works the best for you is fine for me. If the wireless tree,
> feel free to add:
> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxx>
> to the patch.

Thanks. I'm going to resend the patch to John with your Signed-off-by -- in case.


--
Ciao
Stefano
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/