Re: [PATCH] sata_nv: fix ADMA ATAPI issues with memory over 4GB (v3)

[Robert Hancock]

Jeff Garzik wrote:
> Robert Hancock wrote:
> > Based on a quick look at sata_mv it appears it sets a 64-bit DMA mask 
> > unconditionally, but for non-ATA_PROT_DMA commands (which includes all 
> > ATAPI), it just falls back to ata_qc_issue_prot which issues via the 
> > legacy SFF interface and can only handle 32-bit addressing. So yes, it 
> > appears to have a similar bug as sata_nv had.
>
>
> sata_mv doesn't do ATAPI at all...

Right.. missed that ATA_FLAG_NO_ATAPI. So these issues Tom is reporting 
are just with a normal SATA hard drive?

--
Robert Hancock      Saskatoon, SK, Canada
To email, remove "nospam" from hancockr@xxxxxxxxxxxxx
Home Page: http://www.roberthancock.com/


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/