[PATCH RFC] [3/9] modpost: Declare the modpost error functions as printf like

From: Andi Kleen
Date: Wed Nov 21 2007 - 21:44:25 EST



This way gcc can warn for wrong format strings

---
scripts/mod/modpost.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)

Index: linux/scripts/mod/modpost.c
===================================================================
--- linux.orig/scripts/mod/modpost.c
+++ linux/scripts/mod/modpost.c
@@ -33,7 +33,9 @@ enum export {
export_unused_gpl, export_gpl_future, export_unknown
};

-void fatal(const char *fmt, ...)
+#define PRINTF __attribute__ ((format (printf, 1, 2)))
+
+PRINTF void fatal(const char *fmt, ...)
{
va_list arglist;

@@ -46,7 +48,7 @@ void fatal(const char *fmt, ...)
exit(1);
}

-void warn(const char *fmt, ...)
+PRINTF void warn(const char *fmt, ...)
{
va_list arglist;

@@ -57,7 +59,7 @@ void warn(const char *fmt, ...)
va_end(arglist);
}

-void merror(const char *fmt, ...)
+PRINTF void merror(const char *fmt, ...)
{
va_list arglist;

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/