Re: [PATCH] Add the word 'Warning' in check_nmi_watchdog() output

[Thomas Gleixner]

On Wed, 21 Nov 2007, Don Zickus wrote:

> On Wed, Nov 21, 2007 at 10:34:59AM -0800, Arjan van de Ven wrote:
> > On Wed, 21 Nov 2007 12:14:20 -0500
> > Don Zickus <dzickus@xxxxxxxxxx> wrote:
> > 
> > > Our automated test suite looks for keywords like error, fail, warning
> > > in the boot log.  In the case when the nmi watchdog is determined to
> > > be stuck in check_nmi_watchdog(), none of those keywords are
> > > displayed.
> > 
> > 
> > please make it at least consistent with the other kernel level bad
> > things, and use "WARNING:"....
> 
> Good point.  I'll repost.

Before you repost, please add an appropriate KERN_WARN prefix to the
printk and run your patch through scripts/checkpatch.pl.

	tglx
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/