Re: [PATCH 13/18] x86 vDSO: ia32 sysenter_return

[Roland McGrath]

> > @@ -104,7 +103,7 @@ ENTRY(ia32_sysenter_target)
> >  	pushfq
> >  	CFI_ADJUST_CFA_OFFSET 8
> >  	/*CFI_REL_OFFSET rflags,0*/
> > -	movl	$VSYSCALL32_SYSEXIT, %r10d
> > +	movl	8*3-THREAD_SIZE+threadinfo_sysenter_return(%rsp), %r10d
> 
> 8*3-THREAD_SIZE is not very intuitive.  Can you add a comment on the
> math?

When you are reading the whole stretch of code right there, and not just
the patch, it's fairly obvious that it matches the three pushes right there.


Thanks,
Roland
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/