Re: [patch][v2] x86, ptrace: support for branch trace store(BTS)

[Andi Kleen]

> - the internal buffer interpretation as well as the corresponding
>   operations are selected at run-time by hardware detection
>   - different processors use different branch record formats

I still think it would be far better if you would switch this over to be table
driven. e.g. define a record that contains offsetof()/sizeof() of the 
different formats and use generic functions. That would decrease
code size considerably.

Also those manpages are really needed.

And your patch seems to be word wrapped.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/